Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when filtering read entries #10704

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

315157973
Copy link
Contributor

Motivation

When ConcurrentOpenLongPairRangeSet does not contain any data, calling span() will throw NPE

Modifications

return null instead

@315157973 315157973 closed this May 25, 2021
@315157973 315157973 reopened this May 25, 2021
@lhotari
Copy link
Member

lhotari commented May 25, 2021

Nice catch!

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdhabalia
Copy link
Contributor

/pulsarbot run-failure-checks

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 6ab493c into apache:master May 26, 2021
@codelipenghui codelipenghui added the type/bug The PR fixed a bug or issue reported a bug label May 26, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone May 26, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
### Motivation
When ConcurrentOpenLongPairRangeSet does not contain any data, calling span() will throw NPE

### Modifications
return null instead
@315157973 315157973 deleted the npe branch July 19, 2021 11:11
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Nov 24, 2021
### Motivation
When ConcurrentOpenLongPairRangeSet does not contain any data, calling span() will throw NPE

### Modifications
return null instead

(cherry picked from commit 6ab493c)
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation
When ConcurrentOpenLongPairRangeSet does not contain any data, calling span() will throw NPE

### Modifications
return null instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants