Fix inconsistent behavior in LongPairRangeSet #10713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 26, 2021
codelipenghui
added
the
type/enhancement
eolivelli
reviewed
May 26, 2021
pulsar-common/src/test/java/org/apache/pulsar/common/util/collections/DefaultRangeSetTest.java
Show resolved
Hide resolved
eolivelli
reviewed
May 26, 2021
merlimat
approved these changes
May 26, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
* fix inconsistent behavior * add unit test * fix unit test * add unit test
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 24, 2021
* fix inconsistent behavior * add unit test * fix unit test * add unit test (cherry picked from commit 4b2c673)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* fix inconsistent behavior * add unit test * fix unit test * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now
LongPairRangeSethas two implementation classes: ConcurrentOpenLongPairRangeSet and DefaultRangeSetBut their behavior in some methods is inconsistent, such as: firstRange, lastRange
If there is no data, in ConcurrentOpenLongPairRangeSet, the above two methods will return null.
NoSuchElementException will be thrown in DefaultRangeSet, which is the default behavior of Guava Range.
When I was using this interface, it was very troublesome to deal with abnormal scenarios. I needed to determine whether it was null and add try-catch, so it is better to make the behavior of the current implementation class consistent.
Either throw an exception or return null, I chose to return null
Modifications
Verifying this change