[Transaction] Transaction admin api get pending ack internal stats #10725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tr_internal_stats # Conflicts: # pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
…/admin/Transactions.java Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
…tr_internal_stats # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java # pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TransactionsImpl.java # pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/PulsarAdminToolTest.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java
…tats' of https://github.com/congbobo184/pulsar into congbobo184_transaction_admin_api_coordinatr_internal_stats
congbobo184
added
the
doc
eolivelli
approved these changes
May 27, 2021
| cs.cursorLedger = cursor.getCursorLedger(); | ||
| cs.cursorLedgerLastEntry = cursor.getCursorLedgerLastEntry(); | ||
| cs.individuallyDeletedMessages = cursor.getIndividuallyDeletedMessages(); | ||
| cs.lastLedgerSwitchTimestamp = DateFormatter.format(cursor.getLastLedgerSwitchTimestamp()); |
There was a problem hiding this comment.
can this getLastLedgerSwitchTimestamp return null ?
There was a problem hiding this comment.
This method does not seem to be used anymore, I forgot to delete it.
Anonymitaet
reviewed
May 27, 2021
| /** | ||
| * Get managed ledger internal stats | ||
| * | ||
| * @param includeLedgerMetadata the flag to control it include ledger metadata |
There was a problem hiding this comment.
control it
What does "it" refer to?
| * Get transaction coordinator internal stats. | ||
| * | ||
| * @param coordinatorId the coordinator ID | ||
| * @param metadata is get ledger metadata |
There was a problem hiding this comment.
Suggested change
| * @param metadata is get ledger metadata | |
| * @param metadata the ledger metadata |
do you mean this?
There was a problem hiding this comment.
whether to get metadata
| /** | ||
| * Get transaction coordinator internal stats. | ||
| * | ||
| * @param coordinatorId the coordinator id |
There was a problem hiding this comment.
Suggested change
| * @param coordinatorId the coordinator id | |
| * @param coordinatorId the coordinator ID |
| * | ||
| * @param topic the topic of get pending ack internal stats | ||
| * @param subName the subscription name of this pending ack | ||
| * @param metadata whether to obtain ledger metadata |
There was a problem hiding this comment.
Suggested change
| * @param metadata whether to obtain ledger metadata | |
| * @param metadata whether to obtain ledger metadata |
double check: whether to obtain ledger metadata? or * @param metadata the ledger metadata
| /** The total number of entries being tracked. */ | ||
| public long numberOfEntries; | ||
|
|
||
| /**The total storage size of all messages (in bytes). */ |
There was a problem hiding this comment.
from this line, there is no space after /**, is this an intended behavior?
congbobo184
changed the title
added 7 commits
May 27, 2021 20:39
…tats' into congbobo184_transaction_admin_api_get_buffer_internal_stats # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TransactionsImpl.java
…tr_internal_stats
…tats' into congbobo184_transaction_admin_api_get_buffer_internal_stats
…er_internal_stats # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/v3/AdminApiTransactionTest.java # pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TransactionsImpl.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java
codelipenghui
approved these changes
May 28, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
May 29, 2021
…pache#10725) ## Motivation Transaction add admin api `getPendingAckInternalStats` ## implement ``` /** * Transaction pending ack internal stats. */ public class TransactionPendingAckInternalStats { /** The manage ledger internal stats*/ public ManagedLedgerInternalStats managedLedgerInternalStats; } ```
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
…pache#10725) ## Motivation Transaction add admin api `getPendingAckInternalStats` ## implement ``` /** * Transaction pending ack internal stats. */ public class TransactionPendingAckInternalStats { /** The manage ledger internal stats*/ public ManagedLedgerInternalStats managedLedgerInternalStats; } ```
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…pache#10725) ## Motivation Transaction add admin api `getPendingAckInternalStats` ## implement ``` /** * Transaction pending ack internal stats. */ public class TransactionPendingAckInternalStats { /** The manage ledger internal stats*/ public ManagedLedgerInternalStats managedLedgerInternalStats; } ```
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…pache#10725) ## Motivation Transaction add admin api `getPendingAckInternalStats` ## implement ``` /** * Transaction pending ack internal stats. */ public class TransactionPendingAckInternalStats { /** The manage ledger internal stats*/ public ManagedLedgerInternalStats managedLedgerInternalStats; } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Transaction add admin api
getPendingAckInternalStatsimplement
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)