[C++] Reduce redeliverMessages when message listener is enabled #10726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
May 27, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
May 29, 2021
…he#10726) ### Motivation When consumer's message listener is enabled, application acknowledge processed message in message listener callback, but still tracks the message in `internalListener`, causes sending redundant redeliverMessages ### Modifications trackMessage before invoke message listener callback in `internalListener`
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
…he#10726) ### Motivation When consumer's message listener is enabled, application acknowledge processed message in message listener callback, but still tracks the message in `internalListener`, causes sending redundant redeliverMessages ### Modifications trackMessage before invoke message listener callback in `internalListener`
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…he#10726) ### Motivation When consumer's message listener is enabled, application acknowledge processed message in message listener callback, but still tracks the message in `internalListener`, causes sending redundant redeliverMessages ### Modifications trackMessage before invoke message listener callback in `internalListener`
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…he#10726) ### Motivation When consumer's message listener is enabled, application acknowledge processed message in message listener callback, but still tracks the message in `internalListener`, causes sending redundant redeliverMessages ### Modifications trackMessage before invoke message listener callback in `internalListener`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When consumer's message listener is enabled, application acknowledge processed message in message listener callback, but still tracks the message in
internalListener, causes sending redundant redeliverMessagesModifications
trackMessage before invoke message listener callback in
internalListenerDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation