Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Cancel scheduled tasks as the first step in closing #10739

Merged
merged 1 commit into from
May 28, 2021
Merged

[ML] Cancel scheduled tasks as the first step in closing #10739

merged 1 commit into from
May 28, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 28, 2021 •
edited
Loading

Motivation

  • when currentLedger was null, the scheduled tasks timeoutTask and checkLedgerRollTask wouldn't get cancelled in asyncClose method since the method gets exited before the tasks are cancelled.

Modifications

  • move the scheduled task cancellation to happen earlier in the asyncClose method, before there is any return; call.

@lhotari
[ML] Cancel scheduled tasks as the first step in closing
2cde98d 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled
@merlimat merlimat added the type/bug The PR fixed a bug or issue reported a bug label May 28, 2021
@merlimat merlimat added this to the 2.8.0 milestone May 28, 2021
@merlimat merlimat merged commit 6a17b3e into apache:master May 28, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request May 29, 2021
@lhotari @yangl
[ML] Cancel scheduled tasks as the first step in closing (apache#10739)
f56b839 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled
wangjialing218 pushed a commit to wangjialing218/pulsar that referenced this pull request May 31, 2021
@lhotari
[ML] Cancel scheduled tasks as the first step in closing (apache#10739)
8a13ad1 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled
lhotari added a commit that referenced this pull request Jun 2, 2021
@lhotari
[ML] Cancel scheduled tasks as the first step in closing (#10739)
3bf7649 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled
@lhotari lhotari added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jun 2, 2021
lhotari added a commit to datastax/pulsar that referenced this pull request Jun 7, 2021
@lhotari
[ML] Cancel scheduled tasks as the first step in closing (apache#10739)
432f096 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled

(cherry picked from commit 3bf7649)
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@lhotari @yangl
[ML] Cancel scheduled tasks as the first step in closing (apache#10739)
5e13acc 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@lhotari @ciaocloud
[ML] Cancel scheduled tasks as the first step in closing (apache#10739)
ab67634 
- when currentLedger was null, the scheduled tasks wouldn't get cancelled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@rdhabalia rdhabalia rdhabalia approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@eolivelli eolivelli Awaiting requested review from eolivelli

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@lhotari lhotari

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.3 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lhotari @merlimat @rdhabalia