[Transaction] Fix transaction ack delete marker position when don't have transaction ack. #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave transaction ack.
congbobo184
requested review from
codelipenghui,
merlimat,
gaoran10 and
eolivelli
…ker_position # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
merlimat
approved these changes
May 29, 2021
eolivelli
approved these changes
May 29, 2021
| * | ||
| * @return the the boolean of teansaction ack existed. | ||
| */ | ||
| boolean isTransactionAckExisted(); |
There was a problem hiding this comment.
What about 'isTransactionAckPresent' ?
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
…ave transaction ack. (apache#10741) ## Motivation Now when broke enable transaction, every ack will check the next position is transaction marker position whether or not. When don't have transaction ack, we don' need to check the next position is transaction marker position. ## implement add the judgement for pending ack delete transaction marker position.
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…ave transaction ack. (apache#10741) ## Motivation Now when broke enable transaction, every ack will check the next position is transaction marker position whether or not. When don't have transaction ack, we don' need to check the next position is transaction marker position. ## implement add the judgement for pending ack delete transaction marker position.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ave transaction ack. (apache#10741) ## Motivation Now when broke enable transaction, every ack will check the next position is transaction marker position whether or not. When don't have transaction ack, we don' need to check the next position is transaction marker position. ## implement add the judgement for pending ack delete transaction marker position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now when broke enable transaction, every ack will check the next position is transaction marker position whether or not. When don't have transaction ack, we don' need to check the next position is transaction marker position.
implement
add the judgement for pending ack delete transaction marker position.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)