Fix kinesis sink backoff class not found #10744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
May 30, 2021
| * All variables are in TimeUnit millis by default. | ||
| */ | ||
| @Data | ||
| public class Backoff { |
There was a problem hiding this comment.
this class is becoming part of the Public API.
please annotate it with Stability annotations.
Can't you move this class to the Kinesis connector module ?
I had a similar discussion with @vroyer that wanted to add a SslConfig class in the public Pulsar IO package.
those additions should be done with care because once we add something to the public API we have to maintain it in the future
There was a problem hiding this comment.
Yes, I think you are right, it seems that not all connectors need this class. I move it to the project Kinesis connector.
codelipenghui
approved these changes
May 31, 2021
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
May 31, 2021
* copy the class `Backoff` to the project Kinesis connector
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
* copy the class `Backoff` to the project Kinesis connector
codelipenghui
pushed a commit
that referenced
this pull request
Jun 27, 2021
* copy the class `Backoff` to the project Kinesis connector (cherry picked from commit e19f647)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* copy the class `Backoff` to the project Kinesis connector
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the class
Backoffin the project Pulsar client impl, the Kinesis sink connector want to use this class, the dependencyorg.apache.pulsar:pulsar-client-originalis needed, but this will increase the connector size, so we could add a new classBackoffin the function io-core, then the classBackoffcould be reused by other connectors.Modifications
Add the class
Backoffin the project function io-core.Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes