add advertised listenerName for geo-replicator #10751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested review from
codelipenghui and
sijie
and removed request for
codelipenghui
codelipenghui
approved these changes
Jun 1, 2021
codelipenghui
requested review from
eolivelli,
congbobo184,
gaoran10,
zymap and
jiazhai
sijie
approved these changes
Jun 1, 2021
zymap
reviewed
Jun 2, 2021
wangjialing218
force-pushed
the
branch_wjl
branch
from
a0fabf1
to
69e0683
Compare
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation In case of geo-replicator, if replicator client can't connect to remote cluster unless using advertised listener, currently there is no way to set advertised listener for replicator. ### Modifications Add listenerName to ClusterData. When creating replicator producer for remote cluster, use listenerName if exists. Add admin cli command to set listenerName for remote cluster.
sijie
pushed a commit
that referenced
this pull request
Jul 14, 2021
### Motivation fix mistake when resolve the conflicts in #10751
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation In case of geo-replicator, if replicator client can't connect to remote cluster unless using advertised listener, currently there is no way to set advertised listener for replicator. ### Modifications Add listenerName to ClusterData. When creating replicator producer for remote cluster, use listenerName if exists. Add admin cli command to set listenerName for remote cluster.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation fix mistake when resolve the conflicts in apache#10751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In case of geo-replicator, if replicator client can't connect to remote cluster unless using advertised listener, currently there is no way to set advertised listener for replicator.
Modifications
Add listenerName to ClusterData.
When creating replicator producer for remote cluster, use listenerName if exists.
Add admin cli command to set listenerName for remote cluster.