[Kinesis] Fix kinesis sink connector does not ack messages #10769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlg99 FYI |
tuteng
approved these changes
Jun 1, 2021
codelipenghui
approved these changes
Jun 1, 2021
|
@tuteng shouldn't it also do |
dlg99
requested changes
Jun 1, 2021
|
@dlg99 there is a retry logic in the |
sijie
approved these changes
Jun 1, 2021
wangjialing218
pushed a commit
to wangjialing218/pulsar
that referenced
this pull request
Jun 2, 2021
…0769) ### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully.
zymap
pushed a commit
that referenced
this pull request
Jun 2, 2021
### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully. (cherry picked from commit b458b4a)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…0769) ### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…0769) ### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when the kinesis sink connector sends the message successfully, it will not ack the message.
Modifications