-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kinesis] Fix kinesis sink connector does not ack messages #10769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dlg99 FYI |
@tuteng shouldn't it also do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also it is missing nack in the onFailure() case
@dlg99 there is a retry logic in the |
…0769) ### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully.
### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully. (cherry picked from commit b458b4a)
…0769) ### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully.
…0769) ### Motivation Currently, when the kinesis sink connector sends the message successfully, it will not ack the message. ### Modifications * Ack messages after the sink connector send messages successfully.
Motivation
Currently, when the kinesis sink connector sends the message successfully, it will not ack the message.
Modifications