Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 10781][pulsar-functions] fix build failure because of spotbugs #10792

Merged
merged 1 commit into from
Jun 25, 2021
Merged

[Issue 10781][pulsar-functions] fix build failure because of spotbugs #10792

merged 1 commit into from
Jun 25, 2021

Conversation

Jason918
Copy link
Contributor

@Jason918 Jason918 commented Jun 3, 2021 •
edited
Loading

Fixes #10781

Motivation

solving build failure case causing by spotbugs issue which is explained in #10781

Modifications

Small modification: add a null check in BKStateStoreImpl.java:[line 175]

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Jason918
Copy link
Contributor Author

Jason918 commented Jun 3, 2021

Hi @jiazhai @codelipenghui , can you please take a look?

@sijie sijie added this to the 2.9.0 milestone Jun 18, 2021
@sijie sijie merged commit 296ba76 into apache:master Jun 25, 2021
codelipenghui pushed a commit that referenced this pull request Jul 7, 2021
@Jason918 @codelipenghui
fix #10781 Build failure because of spotbugs (#10792)
706f138 
Fixes #10781 

### Motivation

solving build failure case causing by spotbugs issue which is explained in #10781 

### Modifications

Small modification: add a null check in BKStateStoreImpl.java:[line 175]

(cherry picked from commit 296ba76)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 7, 2021
@Jason918 Jason918 deleted the fix-spotbugs branch July 26, 2021 02:55
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@Jason918 @ciaocloud
fix apache#10781 Build failure because of spotbugs (apache#10792)
9ab07e5 
Fixes apache#10781 

### Motivation

solving build failure case causing by spotbugs issue which is explained in apache#10781 

### Modifications

Small modification: add a null check in BKStateStoreImpl.java:[line 175]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@freeznet freeznet freeznet approved these changes

@jerrypeng jerrypeng jerrypeng approved these changes

Assignees

@Jason918 Jason918

Labels
area/function cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Build failure because of spotbugs
5 participants
@Jason918 @sijie @freeznet @jerrypeng @codelipenghui