[Build] Support building site without CROWDIN_DOCUSAURUS_API_KEY #10804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
reviewed
Jun 3, 2021
|
|
||
| # TODO: remove this after figuring out why crowdin removed code tab when generating translated files |
There was a problem hiding this comment.
if you are touching this file, can you move all the cp commands into a shell function?
There was a problem hiding this comment.
There was a problem hiding this comment.
there is nothing related to crowdin. this is just a review comment on the shell script.
There was a problem hiding this comment.
ok, I'll extract a shell function.
There was a problem hiding this comment.
@sijie I have now extracted a shell function. PTAL
There was a problem hiding this comment.
I currently think this part can be removed, because newer versions since 2.5.2 have not added the corresponding content, but the site is built successfully, so I will consider doing a test to decide whether to remove the hack content
- build English site when key isn't set - this is useful for debugging and improving the Website build
lhotari
force-pushed
the
lh-allow-running-website-build-locally
branch
from
b34f43f
to
aca80df
Compare
sijie
approved these changes
Jun 3, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…che#10804) * Support building site without CROWDIN_DOCUSAURUS_API_KEY - build English site when key isn't set - this is useful for debugging and improving the Website build * Add review feedback: extract shell function
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…che#10804) * Support building site without CROWDIN_DOCUSAURUS_API_KEY - build English site when key isn't set - this is useful for debugging and improving the Website build * Add review feedback: extract shell function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The website build is currently broken and there's a need to debug the issues locally in order to fix the problems.
With the PR changes, it's possible to build the site with these commands locally:
Modifications
Support building site without
CROWDIN_DOCUSAURUS_API_KEY