Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoClassDefFoundError when running pulsar cli tools in dev directory #10807

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 3, 2021

Fixes #10802

Motivation

See #10802

Modifications

  • when running pulsar cli tools in a docker container, the cached
    distribution/server/target/classpath.txt must be removed since it
    contains absolute paths

  • the generation of the distribution/server/target/classpath.txt file was invalid
    in the cli scripts. mvn -pl distribution/server generate-sources
    should be used to create the file since that's how the main build generates the file.

… directory

Fixes apache#10802

- when running pulsar cli tools in a docker container, the cached
  distribution/server/target/classpath.txt must be removed since it
  contains absolute paths

- the generation of distribution/server/target/classpath.txt was invalid
  in the cli scripts. "mvn -pl distribution/server generate-sources"
  should be used to create the file.
@lhotari
Copy link
Member Author

lhotari commented Jun 3, 2021

@sijie @tuteng Please review this asap. This fixes an issue in the Pulsar website build reported as #10802 .

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari mentioned this pull request Jun 3, 2021
5 tasks
@lhotari lhotari added this to the 2.8.0 milestone Jun 3, 2021
@lhotari lhotari self-assigned this Jun 3, 2021
@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Jun 3, 2021
@codelipenghui codelipenghui merged commit d57b316 into apache:master Jun 3, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
… directory (apache#10807)

Fixes apache#10802

- when running pulsar cli tools in a docker container, the cached
  distribution/server/target/classpath.txt must be removed since it
  contains absolute paths

- the generation of distribution/server/target/classpath.txt was invalid
  in the cli scripts. "mvn -pl distribution/server generate-sources"
  should be used to create the file.
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
… directory (apache#10807)

Fixes apache#10802

- when running pulsar cli tools in a docker container, the cached
  distribution/server/target/classpath.txt must be removed since it
  contains absolute paths

- the generation of distribution/server/target/classpath.txt was invalid
  in the cli scripts. "mvn -pl distribution/server generate-sources"
  should be used to create the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website build] pulsar-admin-doc-gen.sh fails with NoClassDefFoundError error
3 participants