Load credentials from secrets for Kinesis connectors #10822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
approved these changes
Jun 4, 2021
tuteng
added
component/connect
type/enhancement
freeznet
approved these changes
Jun 4, 2021
nlu90
approved these changes
Jun 4, 2021
sijie
approved these changes
Jun 7, 2021
|
@fantapsody thanks for your contribution. For this PR, do we need to update docs? |
codelipenghui
approved these changes
Jun 8, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
### Motivation Support loading `awsCredentialPluginParam` from secrets for kinesis connectors to avoid leaking of sensitive information with best efforts. ### Modifications Load kinesis configs with `IOConfigUtils.loadWithSecrets()`. ### Verifying this change This change is already covered by existing tests and this PR also adds tests to confirm both loading credentials from plaintext config object and secrets work as expected.
codelipenghui
pushed a commit
that referenced
this pull request
Jun 25, 2021
### Motivation Support loading `awsCredentialPluginParam` from secrets for kinesis connectors to avoid leaking of sensitive information with best efforts. ### Modifications Load kinesis configs with `IOConfigUtils.loadWithSecrets()`. ### Verifying this change This change is already covered by existing tests and this PR also adds tests to confirm both loading credentials from plaintext config object and secrets work as expected. (cherry picked from commit cb79032)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Support loading `awsCredentialPluginParam` from secrets for kinesis connectors to avoid leaking of sensitive information with best efforts. ### Modifications Load kinesis configs with `IOConfigUtils.loadWithSecrets()`. ### Verifying this change This change is already covered by existing tests and this PR also adds tests to confirm both loading credentials from plaintext config object and secrets work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support loading
awsCredentialPluginParamfrom secrets for kinesis connectors to avoid leaking of sensitive information with best efforts.Modifications
Load kinesis configs with
IOConfigUtils.loadWithSecrets().Verifying this change
This change is already covered by existing tests and this PR also adds tests to confirm both loading credentials from plaintext config object and secrets work as expected.