-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix improper class/method/field modifiers #10837
fix improper class/method/field modifiers #10837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IIRC there is a checkstyle rule, can we activate it please ?
@eolivelli good idea, i work for it. |
0250cbb
to
896a492
Compare
@hangc0276 thanks for your contribution. For this PR, do we need to update docs? |
@Anonymitaet No need to update docs, thanks. |
@eolivelli I have add the modifier order check, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
(cherry picked from commit f25b4a5)
Motivation
The some java class/method/field modifiers are improper used.
Oracle java modifier order documentation:
https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html#jls-8.1.1
Class Modifiers
Method Modifiers
Field Modifiers
Modification
Change mis-ordered modifiers.