Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Pulsar Doc, Transactions Example code #10901

Merged
merged 4 commits into from
Jun 16, 2021
Merged

fix Pulsar Doc, Transactions Example code #10901

merged 4 commits into from
Jun 16, 2021

Conversation

xuesongxs
Copy link
Contributor

fix #10900

@Anonymitaet
Copy link
Member

@congbobo184 could you please help review? Thanks

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 15, 2021
congbobo184
congbobo184 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@congbobo184 congbobo184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@codelipenghui codelipenghui merged commit edc03c0 into apache:master Jun 16, 2021
@codelipenghui codelipenghui added this to the 2.9.0 milestone Jun 16, 2021
@xuesongxs xuesongxs deleted the transaction-example branch June 16, 2021 09:23
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@xuesongxs @yangl
Fix documentation for transactions to disable send timeout by default (…
6dd4eb0 
…apache#10901)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jun 25, 2021
codelipenghui pushed a commit that referenced this pull request Jun 25, 2021
@xuesongxs @codelipenghui
Fix documentation for transactions to disable send timeout by default (…
c2d3707 
…#10901)

(cherry picked from commit edc03c0)
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@xuesongxs @ciaocloud
Fix documentation for transactions to disable send timeout by default (…
46033ef 
…apache#10901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

Assignees

@xuesongxs xuesongxs

Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/2.8.1
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[Pulsar Doc] Transactions Example code error
4 participants
@xuesongxs @Anonymitaet @codelipenghui @congbobo184