When the Replicator is enabled, no managedLedger is created when updating the number of partitions #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l not create managedLedger
| Awaitility.await().untilAsserted(() -> assertNotNull(admin2.topics().getPartitionedTopicList(namespace))); | ||
| Awaitility.await().untilAsserted(() -> assertEquals( | ||
| admin2.topics().getPartitionedTopicList(namespace).get(0), persistentTopicName)); | ||
| assertEquals(admin1.topics().getList(namespace).size(), 3); |
There was a problem hiding this comment.
@315157973 Could you please also add a check for checking we have 3 partitions in the cluster-2(using admin-1)
assertEquals(admin2.topics().getList(namespace).size(), 3);
There was a problem hiding this comment.
Ok i will add this test
There was a problem hiding this comment.
Hello @codelipenghui
admin.topics().getList reads the data under the /managed-ledgers node, which belongs to localZK, so the remote cluster cannot perceive it. This PR mainly fixes the remote replication problem of updatePartitions in issue#10673.
Now the CreatePartitionTopic interface does not have geo-related logic. If we want to add it, we need to add parameters to avoid circular replication. I will open another PR to support replication in CreatePartitionTopic.
eolivelli
approved these changes
Jun 15, 2021
codelipenghui
approved these changes
Jun 17, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jun 17, 2021
…ting the number of partitions (#10910) Fixes #10673 When updating the number of partitions, we need to update the data in two places in zk: ``` /admin/partitioned-topics /managed-ledgers/ ``` Now we only update the number of partitions in `/admin/partitioned-topics`, so if we do not create a Producer or Consumer, the data obtained in another cluster will be incorrect 1）Try to create managedLedger when updating the number of partitions 2）Ensure that the number of partitions in `/admin/partitioned-topics` is updated every time (cherry picked from commit 202da11)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…ting the number of partitions (apache#10910) Fixes apache#10673 ### Motivation When updating the number of partitions, we need to update the data in two places in zk: ``` /admin/partitioned-topics /managed-ledgers/ ``` Now we only update the number of partitions in `/admin/partitioned-topics`, so if we do not create a Producer or Consumer, the data obtained in another cluster will be incorrect ### Modifications 1）Try to create managedLedger when updating the number of partitions 2）Ensure that the number of partitions in `/admin/partitioned-topics` is updated every time
codelipenghui
pushed a commit
that referenced
this pull request
Jun 25, 2021
…ting the number of partitions (#10910) Fixes #10673 ### Motivation When updating the number of partitions, we need to update the data in two places in zk: ``` /admin/partitioned-topics /managed-ledgers/ ``` Now we only update the number of partitions in `/admin/partitioned-topics`, so if we do not create a Producer or Consumer, the data obtained in another cluster will be incorrect ### Modifications 1）Try to create managedLedger when updating the number of partitions 2）Ensure that the number of partitions in `/admin/partitioned-topics` is updated every time (cherry picked from commit 202da11)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ting the number of partitions (apache#10910) Fixes apache#10673 ### Motivation When updating the number of partitions, we need to update the data in two places in zk: ``` /admin/partitioned-topics /managed-ledgers/ ``` Now we only update the number of partitions in `/admin/partitioned-topics`, so if we do not create a Producer or Consumer, the data obtained in another cluster will be incorrect ### Modifications 1）Try to create managedLedger when updating the number of partitions 2）Ensure that the number of partitions in `/admin/partitioned-topics` is updated every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10673
Motivation
When updating the number of partitions, we need to update the data in two places in zk:
Now we only update the number of partitions in
/admin/partitioned-topics, so if we do not create a Producer or Consumer, the data obtained in another cluster will be incorrectModifications
1）Try to create managedLedger when updating the number of partitions
2）Ensure that the number of partitions in
/admin/partitioned-topicsis updated every time