Fix peek message failure when broker entry metadata is enabled #10924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
codelipenghui,
eolivelli,
lhotari,
315157973,
hangc0276,
jiazhai and
sijie
and removed request for
codelipenghui and
eolivelli
codelipenghui
approved these changes
Jun 15, 2021
BewareMyPower
deleted the
bewaremypower/fix-peek-with-broker-entry-metadata
branch
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 15, 2021
…e#10924) ### Motivation When broker entry metadata is enabled, using pulsar-admin to peek messages will fail with ``` [pulsar-web-29-16] ERROR org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Failed to peek message at position 1 from persistent://prop/ns-abc/topic-b604aad8ea8010af my-sub java.lang.IllegalArgumentException: Invalid unknonwn tag type: 6 at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:270) ~[classes/:?] at org.apache.pulsar.common.api.proto.MessageMetadata.parseFrom(MessageMetadata.java:1370) ~[classes/:?] at org.apache.pulsar.common.protocol.Commands.parseMessageMetadata(Commands.java:426) ~[classes/:?] ``` ### Modifications Skip the broker entry metadata if exists in `generateResponseWithEntry` and add the test to verify it. (cherry picked from commit 7603a9d)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 17, 2021
…e#10924) ### Motivation When broker entry metadata is enabled, using pulsar-admin to peek messages will fail with ``` [pulsar-web-29-16] ERROR org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Failed to peek message at position 1 from persistent://prop/ns-abc/topic-b604aad8ea8010af my-sub java.lang.IllegalArgumentException: Invalid unknonwn tag type: 6 at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:270) ~[classes/:?] at org.apache.pulsar.common.api.proto.MessageMetadata.parseFrom(MessageMetadata.java:1370) ~[classes/:?] at org.apache.pulsar.common.protocol.Commands.parseMessageMetadata(Commands.java:426) ~[classes/:?] ``` ### Modifications Skip the broker entry metadata if exists in `generateResponseWithEntry` and add the test to verify it. (cherry picked from commit 7603a9d) (cherry picked from commit 77f8a4f)
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…e#10924) ### Motivation When broker entry metadata is enabled, using pulsar-admin to peek messages will fail with ``` [pulsar-web-29-16] ERROR org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Failed to peek message at position 1 from persistent://prop/ns-abc/topic-b604aad8ea8010af my-sub java.lang.IllegalArgumentException: Invalid unknonwn tag type: 6 at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:270) ~[classes/:?] at org.apache.pulsar.common.api.proto.MessageMetadata.parseFrom(MessageMetadata.java:1370) ~[classes/:?] at org.apache.pulsar.common.protocol.Commands.parseMessageMetadata(Commands.java:426) ~[classes/:?] ``` ### Modifications Skip the broker entry metadata if exists in `generateResponseWithEntry` and add the test to verify it.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…e#10924) ### Motivation When broker entry metadata is enabled, using pulsar-admin to peek messages will fail with ``` [pulsar-web-29-16] ERROR org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Failed to peek message at position 1 from persistent://prop/ns-abc/topic-b604aad8ea8010af my-sub java.lang.IllegalArgumentException: Invalid unknonwn tag type: 6 at org.apache.pulsar.common.api.proto.LightProtoCodec.skipUnknownField(LightProtoCodec.java:270) ~[classes/:?] at org.apache.pulsar.common.api.proto.MessageMetadata.parseFrom(MessageMetadata.java:1370) ~[classes/:?] at org.apache.pulsar.common.protocol.Commands.parseMessageMetadata(Commands.java:426) ~[classes/:?] ``` ### Modifications Skip the broker entry metadata if exists in `generateResponseWithEntry` and add the test to verify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When broker entry metadata is enabled, using pulsar-admin to peek messages will fail with
Modifications
Skip the broker entry metadata if exists in
generateResponseWithEntryand add the test to verify it.Verifying this change
This change added tests and can be verified as follows:
BrokerEntryMetadataE2ETest#testPeekMessage