[Transactions] Prevent NPE in case of closeAsync() without a successful execution of startAsync() #10948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ul execution of startAsync()
codelipenghui
approved these changes
Jun 17, 2021
yangl
pushed a commit
to yangl/pulsar
that referenced
this pull request
Jun 23, 2021
…ul execution of startAsync() (apache#10948) Fixes apache#10947 ### Motivation If the initialisation of TransactionCoordinatorClientImpl is not completed calling closeAsync will result in a NPE.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ul execution of startAsync() (apache#10948) Fixes apache#10947 ### Motivation If the initialisation of TransactionCoordinatorClientImpl is not completed calling closeAsync will result in a NPE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10947
Motivation
If the initialisation of TransactionCoordinatorClientImpl is not completed calling closeAsync will result in a NPE.
Modifications
Add a null check
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.