-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the nar package name for pulsar-io-kafka-connect-adaptor #10976
Change the nar package name for pulsar-io-kafka-connect-adaptor #10976
Conversation
We have change the nar package name in apache#9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that this won't break something downstream for the users of this module.
probably it is not a problem
@dlg99 would you mind to take a look ?
you talked about this module at PulsarSummit
I don't think it will break anything, but it might be confusing (as in: tracking what builds the file) given existing pulsar/pulsar-io/kafka-connect-adaptor module. |
Integration tests failed. |
@codelipenghui integration tests failed with
probably need to update
|
Thanks @dlg99 @eolivelli. Will fix the tests soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…he#10976) * Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in apache#9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests.
* Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in #9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests. (cherry picked from commit 16667d8)
…he#10976) * Change the nar package name for pulsar-io-kafka-connect-adaptor We have change the nar package name in apache#9808 which will broken the website download link, The reported issue is https://issues.apache.org/jira/browse/PULSAR-16 * Fix tests.
We have change the nar package name in #9808 which will broken the website download link,
The reported issue is https://issues.apache.org/jira/browse/PULSAR-16