[Python] Fixed import when AvroSchema is not being used #11034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
BewareMyPower
approved these changes
Jun 23, 2021
sijie
approved these changes
Jun 24, 2021
kaushik-develop
pushed a commit
to kaushik-develop/pulsar
that referenced
this pull request
Jun 24, 2021
### Motivation Fixes apache#10929 Since by default we're not marking `fastavro` as a dependency, we shouldn't failing when the dependency is not there, unless a user is really trying to use `AvroSchema`, in which case we should give a useful error message.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Fixes apache#10929 Since by default we're not marking `fastavro` as a dependency, we shouldn't failing when the dependency is not there, unless a user is really trying to use `AvroSchema`, in which case we should give a useful error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #10929
Since by default we're not marking
fastavroas a dependency, we shouldn't failing when the dependencyis not there, unless a user is really trying to use
AvroSchema, in which case we should give a useful error message.