[Broker] Fix async response filter #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
zymap,
315157973,
codelipenghui,
congbobo184,
eolivelli and
tuteng
sijie
approved these changes
Jun 25, 2021
codelipenghui
approved these changes
Jun 27, 2021
eolivelli
reviewed
Jun 27, 2021
|
|
||
| @Slf4j | ||
| public class CounterBrokerInterceptor implements BrokerInterceptor { | ||
|
|
||
| int beforeSendCount = 0; | ||
| int count = 0; | ||
| private List<ResponseEvent> responseList = new ArrayList<>(); |
There was a problem hiding this comment.
This is wrong,
This list does not support concurrent access.
We should use CopyOnWriteArrayList
There was a problem hiding this comment.
Good point, @gaoran10 Could you please push a PR for fixing this one?
There was a problem hiding this comment.
Ok, I'll fix it. But this class is used for testing, maybe there is only one admin client for testing in normal cases.
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
### Motivation Currently, the response filter couldn't process async responses correctlly, the response interceptor may be called before the async response returning. ### Modifications Add listener when using async request. ### Verifying this change Add a new test to verify the response interceptor is called after async response returning. (cherry picked from commit 3c8d210)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Currently, the response filter couldn't process async responses correctlly, the response interceptor may be called before the async response returning. ### Modifications Add listener when using async request. ### Verifying this change Add a new test to verify the response interceptor is called after async response returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the response filter couldn't process async responses correctlly, the response interceptor may be called before the async response returning.
Modifications
Add listener when using async request.
Verifying this change
Add a new test to verify the response interceptor is called after async response returning.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes