Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 11067][pulsar-client] Fix bin/pulsar-client produce not supporting v2 topic name through websocket #11069

Merged
merged 1 commit into from
Jul 6, 2021
Merged

[Issue 11067][pulsar-client] Fix bin/pulsar-client produce not supporting v2 topic name through websocket #11069

merged 1 commit into from
Jul 6, 2021

Conversation

Jason918
Copy link
Contributor

Fixes #11067

Motivation

Fix bin/pulsar-client produce not supporting v2 topic name through websocket.

Modifications

Add "v2" in websoket url if topicName is in v2 format.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests in org.apache.pulsar.client.cli.TestCmdProduce#testGetProduceBaseEndPoint

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Jason918
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Jason918
Copy link
Contributor Author

@codelipenghui Hi, can you please take a look?

@codelipenghui codelipenghui added this to the 2.9.0 milestone Jul 5, 2021
@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug area/websocket labels Jul 5, 2021
@sijie sijie merged commit b4780ff into apache:master Jul 6, 2021
codelipenghui pushed a commit that referenced this pull request Jul 7, 2021
@Jason918 @codelipenghui
[Issue 11067][pulsar-client] Fix bin/pulsar-client produce not suppo…
01f1596 
…rting v2 topic name through websocket (#11069)

Fixes #11067


### Motivation

Fix bin/pulsar-client produce not supporting v2 topic name through websocket.

### Modifications

Add "v2" in websoket url if topicName is in v2 format.

(cherry picked from commit b4780ff)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 7, 2021
@Jason918 Jason918 deleted the issue-11067 branch July 26, 2021 02:55
dlg99 pushed a commit to dlg99/pulsar that referenced this pull request Feb 28, 2022
@Jason918 @dlg99
[Issue 11067][pulsar-client] Fix bin/pulsar-client produce not suppo…
11e8172 
…rting v2 topic name through websocket (apache#11069)

Fixes apache#11067

### Motivation

Fix bin/pulsar-client produce not supporting v2 topic name through websocket.

### Modifications

Add "v2" in websoket url if topicName is in v2 format.

(cherry picked from commit b4780ff)
@dlg99 dlg99 mentioned this pull request Feb 28, 2022
Merged
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Mar 1, 2022
@Jason918 @eolivelli
[Issue 11067][pulsar-client] Fix bin/pulsar-client produce not suppo…
c56000e 
…rting v2 topic name through websocket (apache#11069)

Fixes apache#11067

### Motivation

Fix bin/pulsar-client produce not supporting v2 topic name through websocket.

### Modifications

Add "v2" in websoket url if topicName is in v2 format.

(cherry picked from commit b4780ff)
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@Jason918 @ciaocloud
[Issue 11067][pulsar-client] Fix bin/pulsar-client produce not suppo…
286b240 
…rting v2 topic name through websocket (apache#11069)

Fixes apache#11067


### Motivation

Fix bin/pulsar-client produce not supporting v2 topic name through websocket.

### Modifications

Add "v2" in websoket url if topicName is in v2 format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@315157973 315157973 Awaiting requested review from 315157973

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@hangc0276 hangc0276 Awaiting requested review from hangc0276

Assignees

@Jason918 Jason918

Labels
area/websocket cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

pulsar-client produce failed sending v2 topic name through websocket
3 participants
@Jason918 @sijie @codelipenghui