Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 11075][Python] Use the subscription name defined in function details #11076

Merged
merged 1 commit into from
Jun 25, 2021
Merged

[Issue 11075][Python] Use the subscription name defined in function details #11076

merged 1 commit into from
Jun 25, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 24, 2021

Fixes #11075

Motivation

See #11075 , python functions don't use the given subscription name for the input topic consumer.

Modifications

Use function_details.source.subscriptionName as the subscription name if it's non-blank.

@lhotari lhotari added the type/bug The PR fixed a bug or issue reported a bug label Jun 24, 2021
@lhotari lhotari added this to the 2.9.0 milestone Jun 24, 2021
@lhotari lhotari self-assigned this Jun 24, 2021
@lhotari lhotari changed the title [Issue 11075] Use the subscription name defined in function details [Issue 11075][Python] Use the subscription name defined in function details Jun 24, 2021
eolivelli
eolivelli approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

In theory there is no backward compatibility problem
Because if someone tried to set a subscription name it didn't work

@sijie sijie merged commit 05ca2b5 into apache:master Jun 25, 2021
codelipenghui pushed a commit that referenced this pull request Jun 25, 2021
@lhotari @codelipenghui
[Issue 11075] Use the subscription name defined in function details (#…
4cf7165 
…11076)

Fixes #11075

### Motivation

See #11075 , python functions don't use the given subscription name for the input topic consumer.

### Modifications

Use `function_details.source.subscriptionName` as the subscription name if it's non-blank. 

(cherry picked from commit 05ca2b5)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jun 25, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@lhotari @ciaocloud
[Issue 11075] Use the subscription name defined in function details (a…
d151af7 
…pache#11076)

Fixes apache#11075

### Motivation

See apache#11075 , python functions don't use the given subscription name for the input topic consumer.

### Modifications

Use `function_details.source.subscriptionName` as the subscription name if it's non-blank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@freeznet freeznet freeznet approved these changes

@eolivelli eolivelli eolivelli approved these changes

@addisonj addisonj Awaiting requested review from addisonj

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@gaoran10 gaoran10 Awaiting requested review from gaoran10

Assignees

@lhotari lhotari

Labels
area/function cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

[Functions] Python instance doesn't use the given subscription name for input topic consumer
5 participants
@lhotari @sijie @freeznet @eolivelli @codelipenghui