[python functions] use keyword argument to create pulsar_client
#11080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Jun 24, 2021
merlimat
approved these changes
Jun 24, 2021
kaushik-develop
pushed a commit
to kaushik-develop/pulsar
that referenced
this pull request
Jun 24, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
(cherry picked from commit eafe7dd)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar's Python client defines
Clientclass with multiple arguments which have a default value, this allows user to initClientclass with keyword argument style.Currently, python functions runtime uses positional argument style, which will have accidentally issues if other contributors add a new argument and not put the new argument as the last one.
Modifications
use keyword argument style to create
pulsar_clientin python functions runtime.Verifying this change