[python functions] fix tls_validate_hostname is not supported in python functions runtime
#11087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Jul 14, 2021
|
@nlu90 Can you review this? |
nlu90
approved these changes
Jul 15, 2021
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jul 21, 2021
… in python functions runtime (apache#11087)" This reverts commit a14f1c5.
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 22, 2021
…on functions runtime (apache#11087) ### Motivation Pulsar's python client support define TLS parameters, like `tls_validate_hostname`, but in python functions runtime, it is not been set properly. ### Modifications - get `hostname_verification_enabled` from python instance arguments - pass `hostname_verification_enabled` to pulsar client ### Verifying this change - [x] Make sure that the change passes the CI checks.
codelipenghui
pushed a commit
that referenced
this pull request
Jul 23, 2021
…on functions runtime (#11087) ### Motivation Pulsar's python client support define TLS parameters, like `tls_validate_hostname`, but in python functions runtime, it is not been set properly. ### Modifications - get `hostname_verification_enabled` from python instance arguments - pass `hostname_verification_enabled` to pulsar client ### Verifying this change - [x] Make sure that the change passes the CI checks. (cherry picked from commit a14f1c5)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…on functions runtime (apache#11087) ### Motivation Pulsar's python client support define TLS parameters, like `tls_validate_hostname`, but in python functions runtime, it is not been set properly. ### Modifications - get `hostname_verification_enabled` from python instance arguments - pass `hostname_verification_enabled` to pulsar client ### Verifying this change - [x] Make sure that the change passes the CI checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar's python client support define TLS parameters, like
tls_validate_hostname, but in python functions runtime, it is not been set properly.Modifications
hostname_verification_enabledfrom python instance argumentshostname_verification_enabledto pulsar clientVerifying this change