-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GetListInBundle return all Topics in bundle #11110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
approved these changes
Jun 26, 2021
codelipenghui
approved these changes
Jun 26, 2021
@315157973 does this affect docs? |
Does not affect the docs |
hangc0276
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
https://github.com/apache/pulsar/blob/7824325efc822307f60b38e9d24bdb189e415a06/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/NonPersistentTopics.java#L310-L313 1. `getListFromBundle` in NonPersistentTopics should only return the list of non-persistent topics under a namespace bundle. But now it returns all the topics. 2. Now it will traverse all topics on Broker. When there are a lot of topics, timeouts often occur. ![image](https://user-images.githubusercontent.com/9758905/123505745-67815d80-d693-11eb-87bb-ef3287668155.png) I will support getting all topics or only persistent topics in another PR 1) Filter out persistent topics 2) Only traverse the topics under the corresponding bundle (cherry picked from commit a6ab3af)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation https://github.com/apache/pulsar/blob/7824325efc822307f60b38e9d24bdb189e415a06/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/NonPersistentTopics.java#L310-L313 1. `getListFromBundle` in NonPersistentTopics should only return the list of non-persistent topics under a namespace bundle. But now it returns all the topics. 2. Now it will traverse all topics on Broker. When there are a lot of topics, timeouts often occur. ![image](https://user-images.githubusercontent.com/9758905/123505745-67815d80-d693-11eb-87bb-ef3287668155.png) I will support getting all topics or only persistent topics in another PR ### Modifications 1) Filter out persistent topics 2) Only traverse the topics under the corresponding bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.8
Archived: 2.8 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.8.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/NonPersistentTopics.java
Lines 310 to 313 in 7824325
getListFromBundle
in NonPersistentTopics should only return the list of non-persistent topics under a namespace bundle.But now it returns all the topics.
Now it will traverse all topics on Broker. When there are a lot of topics, timeouts often occur.
![image](https://user-images.githubusercontent.com/9758905/123505745-67815d80-d693-11eb-87bb-ef3287668155.png)
I will support getting all topics or only persistent topics in another PR
Modifications
Verifying this change