[C++] Fix missed header for some compilers #11152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
merlimat,
codelipenghui,
jiazhai,
k2la and
sijie
k2la
approved these changes
Jun 29, 2021
merlimat
approved these changes
Jun 30, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit 6c1d510)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Visual Studio 2017 cannot compile the code of latest master
It's introduced from #11088. For some compilers,
std::maxmight be included implicitly, but C++ standard only requires that it's included in<algorithm>header, see https://en.cppreference.com/w/cpp/algorithm/max for reference.Modifications
Include
<algorithm>header forstd::maxfunction.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.