[admin] Enable peeking encrypted batch messages #11244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We can peek non-batched messages successfully, even if they are encrypted:
On the other hand, if batched messages are encrypted, an exception will be thrown when peeking:
This is probably because the payload of the batch message is encrypted and it fails to retrieve the individual payloads from it.
Modifications
When an encrypted message is peeked, the broker returns a response with the value of the
X-Pulsar-Is-Encrypted
header set to true. Then, admin client treats it as a non-batch message and creates aMessageImpl
instance. This fix enables us to peek the message without throwing an exception.