[pulsar function] add instanceId and fqn into log message properties #11399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
|
There's no doc about the existing property for log topic. It's good to mention the available propperties for a log message, but I don't know where to add this. |
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Jul 21, 2021
Anonymitaet
added
the
doc-required
|
@nlu90 thanks. You can ping me if you need a doc review. |
freeznet
approved these changes
Jul 22, 2021
|
/pulsarbot run-failure-checks |
nlu90
force-pushed
the
neng/log-topic-property
branch
from
fb1bbda
to
90058a0
Compare
|
/pulsarbot run-failure-checks |
|
@nlu90 you might need to rebase to the latest master to include CI fixes. |
nlu90
force-pushed
the
neng/log-topic-property
branch
from
90058a0
to
4ba76df
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
### Motivation Enrich the published log message with `instanceId` and `fqn` set in properties. ### Modifications add `instanceId` and `fqn` into log message properties (cherry picked from commit b6d02e4)
Anonymitaet
removed
the
doc-required
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Enrich the published log message with `instanceId` and `fqn` set in properties. ### Modifications add `instanceId` and `fqn` into log message properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enrich the published log message with
instanceIdandfqnset in properties.Modifications
add
instanceIdandfqninto log message propertiesVerifying this change