Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar function] set exposePulsarAdmin to true if enabled #11417

Merged
merged 5 commits into from
Jul 26, 2021

Conversation

nlu90
Copy link
Member

@nlu90 nlu90 commented Jul 22, 2021

Fixes #11416

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

For contributor

For this PR, do we need to update docs?

No. Internal bug fix

@sijie sijie added this to the 2.9.0 milestone Jul 22, 2021
@sijie
Copy link
Member

sijie commented Jul 22, 2021

@nlu90 you might need to rebase to the latest master to include CI fixes.

@nlu90
Copy link
Member Author

nlu90 commented Jul 22, 2021

/pulsarbot run-failure-checks

1 similar comment
@freeznet
Copy link
Contributor

/pulsarbot run-failure-checks

@nlu90 nlu90 changed the title set exposePulsarAdmin to true if enabled [pulsar function] set exposePulsarAdmin to true if enabled Jul 23, 2021
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codelipenghui codelipenghui merged commit 56722b8 into apache:master Jul 26, 2021
@codelipenghui codelipenghui deleted the neng/expose-pulsar-admin branch July 26, 2021 01:32
codelipenghui pushed a commit that referenced this pull request Jul 30, 2021
Fixes #11416

### Verifying this change

- [ ] Make sure that the change passes the CI checks.

(cherry picked from commit 56722b8)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 30, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
)

Fixes apache#11416

### Verifying this change

- [ ] Make sure that the change passes the CI checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pulsar function] puslarAdmin is not exposed properly even function worker is set to expose it
5 participants