Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate check for replicationClusterSet #11429

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Remove duplicate check for replicationClusterSet #11429

merged 1 commit into from
Jul 23, 2021

Conversation

Technoboy-
Copy link
Contributor

Motivation

NamespacesBase#internalSetNamespaceReplicationClusters has duplicate codes:

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java

Lines 757 to 773 in a6e1a32

Set<String> clusters = clusters();
for (String clusterId : replicationClusterSet) {
if (!clusters.contains(clusterId)) {
throw new RestException(Status.FORBIDDEN, "Invalid cluster id: " + clusterId);
}
validatePeerClusterConflict(clusterId, replicationClusterSet);
}
for (String clusterId : replicationClusterSet) {
if (!clusters.contains(clusterId)) {
throw new RestException(Status.FORBIDDEN, "Invalid cluster id: " + clusterId);
}
validatePeerClusterConflict(clusterId, replicationClusterSet);
}
for (String clusterId : replicationClusterSet) {
validateClusterForTenant(namespaceName.getTenant(), clusterId);
}

Modifications

Remove the duplicate codes.

For contributor

Small code adjustment, no need to update doc.

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Jul 22, 2021
@sijie sijie added this to the 2.9.0 milestone Jul 22, 2021
@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 083bb62 into apache:master Jul 23, 2021
codelipenghui pushed a commit that referenced this pull request Jul 30, 2021
@Technoboy- @codelipenghui
Remove duplicate check for replicationClusterSet (#11429)
d4fd235 
### Motivation
NamespacesBase#internalSetNamespaceReplicationClusters has duplicate codes:
https://github.com/apache/pulsar/blob/a6e1a3290d9eb42f4d03438c3ce9ced506ee8445/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L757-L773

(cherry picked from commit 083bb62)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 30, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@Technoboy- @ciaocloud
Remove duplicate check for replicationClusterSet (apache#11429)
976caa5 
### Motivation
NamespacesBase#internalSetNamespaceReplicationClusters has duplicate codes:
https://github.com/apache/pulsar/blob/a6e1a3290d9eb42f4d03438c3ce9ced506ee8445/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L757-L773
@Technoboy- Technoboy- deleted the remove-duplicate-check branch August 10, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@Technoboy- Technoboy-

Labels
area/admin cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.1
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Technoboy- @sijie @codelipenghui @Anonymitaet