[python] Support CryptoKeyReader for Reader API in python clients #11447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdhabalia - Can you take a look at this? |
BewareMyPower
approved these changes
Jul 24, 2021
sijie
approved these changes
Jul 29, 2021
|
I'm not sure how the python unit-tests would have passed without 57690f7 Also, I believe this documentation section https://pulsar.apache.org/docs/en/client-libraries-python/#end-to-end-encryption would benefit from an update if this PR is merged. |
k2la
approved these changes
Aug 10, 2021
tuteng
approved these changes
Aug 10, 2021
|
Could you rebase to master for the fixed C++ CI? |
Sure. However this will result in a force push to this branch/pr |
Could you fix this error? |
sijie
added
doc-required
sijie
reviewed
Aug 21, 2021
|
Hi @sanjivr Thanks for your great contribution. |
BewareMyPower
pushed a commit
that referenced
this pull request
Oct 15, 2021
…1447) The Reader API in the python client does not support reading an encrypted message. This PR adds the same and leverages existing C++ Reader API which supports the same. * Updated `pulsar.Client.create_reader` to accept `crypto_key_reader` argument * Update existing unit test for Python encryption. (cherry picked from commit f7de12fa52e43f886404968691968b514831dac) Solved conflicts by modifing following files: - pulsar-client-cpp/python/pulsar_test.py - pulsar-client-cpp/python/src/config.cc
Anonymitaet
removed
the
doc-required
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ache#11447) ### Motivation The Reader API in the python client does not support reading an encrypted message. This PR adds the same and leverages existing C++ Reader API which supports the same. ### Modifications * Updated `pulsar.Client.create_reader` to accept `crypto_key_reader` argument * Update existing unit test for Python encryption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Reader API in the python client does not support reading an encrypted message.
This PR adds the same and leverages existing C++ Reader API which supports the same.
Modifications
pulsar.Client.create_readerto acceptcrypto_key_readerargumentVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
No. These updates will be picked up automatically by pdoc as described at https://pulsar.apache.org/docs/en/client-libraries-python/
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doclabel.if you plan to update docs later, label this PR with the
doc-requiredlabel.if you need help on updating docs, create a follow-up issue with the
doc-requiredlabel.If no, label this PR with the
no-need-doclabel and explain why.