[fix] OffloadPoliciesImplBuilder missing method and not implements OffloadPolicies.Builder #11453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implement OffloadPolicies.Builder and missing the method setS3ManagedLedgerOffloadRoleSessionName
lifepuzzlefun
changed the title
lifepuzzlefun
changed the title
lifepuzzlefun
changed the title
sijie
approved these changes
Jul 28, 2021
| @@ -472,7 +472,7 @@ private static Object getCompatibleValue(Properties properties, Field field) { | |||
| return value((String) object, field); | |||
| } | |||
|
|
|||
| public static class OffloadPoliciesImplBuilder { | |||
| public static class OffloadPoliciesImplBuilder implements OffloadPolicies.Builder{ | |||
There was a problem hiding this comment.
Suggested change
| public static class OffloadPoliciesImplBuilder implements OffloadPolicies.Builder{ | |
| public static class OffloadPoliciesImplBuilder implements OffloadPolicies.Builder { |
fix code format
codelipenghui
approved these changes
Aug 2, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…floadPolicies.Builder (apache#11453) * org.apache.pulsar.common.policies.data.OffloadPoliciesImplBuilder not implement OffloadPolicies.Builder and missing the method setS3ManagedLedgerOffloadRoleSessionName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.apache.pulsar.common.policies.data.OffloadPoliciesImplBuilder implement OffloadPolicies.Builder
and missing the method setS3ManagedLedgerOffloadRoleSessionName