Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-io] fix source stats exposing empty exceptions list #11478

Merged

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Jul 28, 2021

Motivation

pulsar-admin sources status always have empty list of latestSystemExceptions and latestSourceExceptions. With some code digging, it turns out that it always returns EMPTY_QUEUE.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

For contributor

For this PR, do we need to update docs?

no, internal bug fix.

@freeznet
Copy link
Contributor Author

@nlu90 @tuteng please help to review this PR if you have time, thanks.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tuteng tuteng added this to the 2.9.0 milestone Jul 28, 2021
@freeznet
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie merged commit 2cefbcc into apache:master Jul 28, 2021
codelipenghui pushed a commit that referenced this pull request Jul 30, 2021
### Motivation

`pulsar-admin sources status` always have empty list of `latestSystemExceptions` and `latestSourceExceptions`. With some code digging, it turns out that it always returns `EMPTY_QUEUE`.

(cherry picked from commit 2cefbcc)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 30, 2021
codelipenghui pushed a commit that referenced this pull request Jul 30, 2021
### Motivation

`pulsar-admin sources status` always have empty list of `latestSystemExceptions` and `latestSourceExceptions`. With some code digging, it turns out that it always returns `EMPTY_QUEUE`.

(cherry picked from commit 2cefbcc)
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jul 30, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…1478)

### Motivation

`pulsar-admin sources status` always have empty list of `latestSystemExceptions` and `latestSourceExceptions`. With some code digging, it turns out that it always returns `EMPTY_QUEUE`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants