-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulsar-io] fix source stats exposing empty exceptions list #11478
Merged
sijie
merged 1 commit into
apache:master
from
freeznet:freeznet/fix-source-stats-exceptions-list
Jul 28, 2021
Merged
[pulsar-io] fix source stats exposing empty exceptions list #11478
sijie
merged 1 commit into
apache:master
from
freeznet:freeznet/fix-source-stats-exceptions-list
Jul 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
approved these changes
Jul 28, 2021
eolivelli
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
/pulsarbot run-failure-checks |
sijie
approved these changes
Jul 28, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
### Motivation `pulsar-admin sources status` always have empty list of `latestSystemExceptions` and `latestSourceExceptions`. With some code digging, it turns out that it always returns `EMPTY_QUEUE`. (cherry picked from commit 2cefbcc)
codelipenghui
pushed a commit
that referenced
this pull request
Jul 30, 2021
### Motivation `pulsar-admin sources status` always have empty list of `latestSystemExceptions` and `latestSourceExceptions`. With some code digging, it turns out that it always returns `EMPTY_QUEUE`. (cherry picked from commit 2cefbcc)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…1478) ### Motivation `pulsar-admin sources status` always have empty list of `latestSystemExceptions` and `latestSourceExceptions`. With some code digging, it turns out that it always returns `EMPTY_QUEUE`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connector
area/function
cherry-picked/branch-2.7
Archived: 2.7 is end of life
cherry-picked/branch-2.8
Archived: 2.8 is end of life
release/2.7.4
release/2.8.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-admin sources status
always have empty list oflatestSystemExceptions
andlatestSourceExceptions
. With some code digging, it turns out that it always returnsEMPTY_QUEUE
.Verifying this change
Documentation
For contributor
For this PR, do we need to update docs?
no, internal bug fix.