[C++] Add padding characters to base64 encoded protobuf native schema #11492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
type/bug
BewareMyPower
requested review from
aahmed-se,
codelipenghui,
jiazhai,
merlimat,
rdhabalia and
sijie
sijie
approved these changes
Jul 29, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 29, 2021
This was referenced Aug 4, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…apache#11492) ### Motivation apache#11388 added support for protobuf native schema in C++ client. The implementation serializes a protobuf generated class' descriptor to a Base64 encoded string. However, it doesn't add the padding characters while the broker side requires the padding characters. Therefore, if the Base64 encoded string needs the padding characters, the broker will fail to deserialize: > com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `byte[]` from String "": Unexpected end of base64-encoded String: base64 variant 'MIME-NO-LINEFEEDS' expects padding (one or more '=' characters) at the end. This Base64Variant might have been incorrectly configured See https://en.wikipedia.org/wiki/Base64#Decoding_Base64_with_padding for the Base64 with padding. ### Modifications - Add the padding `=` characters if the Base64 encoded string's length is not a multiple of four. - Add a `PaddingDemo.proto` to test the above case to ensure that broker can validate the schema string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#11388 added support for protobuf native schema in C++ client. The implementation serializes a protobuf generated class' descriptor to a Base64 encoded string. However, it doesn't add the padding characters while the broker side requires the padding characters. Therefore, if the Base64 encoded string needs the padding characters, the broker will fail to deserialize:
See https://en.wikipedia.org/wiki/Base64#Decoding_Base64_with_padding for the Base64 with padding.
Modifications
=characters if the Base64 encoded string's length is not a multiple of four.PaddingDemo.prototo test the above case to ensure that broker can validate the schema string.Verifying this change
This change added tests
ProtobufNativeSchemaTest. testBase64WithPadding.