Fix time based backlog quota. #11509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time based backlog quota type message_age is set separately but when check backlog we're only checking against destination_storage type. So fix to loop through all BacklogQuotaType when checking if backlog exceeded.
eolivelli
approved these changes
Jul 30, 2021
Anonymitaet
added
the
doc
|
@Anonymitaet updated doc, please take a look. |
codelipenghui
approved these changes
Aug 3, 2021
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java
Outdated
Show resolved
Hide resolved
...nt-admin-api/src/main/java/org/apache/pulsar/common/policies/data/impl/BacklogQuotaImpl.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
release/2.8.1
doc-required
Anonymitaet
approved these changes
Aug 3, 2021
Anonymitaet
added
doc
hangc0276
approved these changes
Aug 5, 2021
...nt-admin-api/src/main/java/org/apache/pulsar/common/policies/data/impl/BacklogQuotaImpl.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
Fixes apache#11404 ### Motivation Time based backlog quota type message_age is set separately but when check backlog we are only checking against destination_storage type. So fix to loop through all BacklogQuotaType when checking if backlog exceeded. ### Modification * Added unit test. * Added default implementation to make Admin Topic/Namespace backlog quota related API backward compatible.
hangc0276
pushed a commit
that referenced
this pull request
Aug 12, 2021
Fixes #11404 ### Motivation Time based backlog quota type message_age is set separately but when check backlog we are only checking against destination_storage type. So fix to loop through all BacklogQuotaType when checking if backlog exceeded. ### Modification * Added unit test. * Added default implementation to make Admin Topic/Namespace backlog quota related API backward compatible. (cherry picked from commit e82df7c)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fixes apache#11404 ### Motivation Time based backlog quota type message_age is set separately but when check backlog we are only checking against destination_storage type. So fix to loop through all BacklogQuotaType when checking if backlog exceeded. ### Modification * Added unit test. * Added default implementation to make Admin Topic/Namespace backlog quota related API backward compatible.
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11404
Motivation
Time based backlog quota type message_age is set separately but when check backlog we're only checking against destination_storage type.
So fix to loop through all BacklogQuotaType when checking if backlog exceeded.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesAdded default implementation to make Admin Topic/Namespace backlog quota related API backward compatible.
Documentation
For contributor
For this PR, do we need to update docs? No