Replace orElse with orElseGet to avoid calling too many times. #11542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
force-pushed
the
replace-orElse-with-orElseGet
branch
from
1c8f7d6
to
602ea02
Compare
|
/pulsarbot run-failure-checks |
|
The patch looks good. I am not sure we achieve some visible improvement because in anyway you are allocating an instance of the lambda expression. Probably the overhead of instantiating such instance will be lower. I am +1 |
If the lambda is not capturing any reference, like |
|
I am not sure if it really happens. |
codelipenghui
approved these changes
Aug 5, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Aug 6, 2021
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 29, 2021
…e#11542) (apache#11542) (cherry picked from commit 27855f8)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use orElseGet when
orElse(xxx)is not a raw value, otherwise it will calling the value every time.Documentation
This is an enhancement, no need to update doc.