[Patch] Fix decode compression managedLedgerInfo data #11569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
changed the title
MLDataFormats.CompressionType in package aged-ledgerMLDataFormats.CompressionType in package managed-ledger
gaoran10
changed the title
MLDataFormats.CompressionType in package managed-ledger
codelipenghui
approved these changes
Aug 5, 2021
hangc0276
approved these changes
Aug 5, 2021
sijie
approved these changes
Aug 5, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Aug 6, 2021
* unify using the class `MLDataFormats.CompressionType` in package `managed-ledger`. * fix compression data decode error (cherry picked from commit f008777)
codelipenghui
pushed a commit
that referenced
this pull request
Aug 6, 2021
* unify using the class `MLDataFormats.CompressionType` in package `managed-ledger`. * fix compression data decode error (cherry picked from commit f008777)
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
* unify using the class `MLDataFormats.CompressionType` in package `managed-ledger`. * fix compression data decode error
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* unify using the class `MLDataFormats.CompressionType` in package `managed-ledger`. * fix compression data decode error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using the broker configuration
managedLedgerInfoCompressionTypeto decode compression managedLedgerInfo data is not right, if the configuration value is changed, the decoding operation will fail.Modification
compressionTypesaved in the managedLedgerInfo metadata to decode compression data.MLDataFormats.CompressionTypein packagemanaged-ledger.Test
Add a test to verify changing compression type, enable managedLedgerInfo compression, and disable managedLedgerInfo compression.