Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP 83 : Pulsar Reader: Message consumption with pooled buffer #11725

Merged
merged 2 commits into from
Aug 21, 2021

Conversation

rdhabalia
Copy link
Contributor

Motivation

#10184 has introduced pooled message support for pulsar-consumer. We would like to extend it for Reader as well.

Modification

This will allow Reader API to read and release pooled messages.

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 20, 2021
…eaderBuilder.java

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@rdhabalia
Copy link
Contributor Author

/pulsarbot run-failure-checks

@rdhabalia rdhabalia merged commit 8d8e6b7 into apache:master Aug 21, 2021
@rdhabalia rdhabalia deleted the reader_pool branch August 21, 2021 07:50
@lhotari
Copy link
Member

lhotari commented Aug 23, 2021

@rdhabalia This PR seems to have introduced a new flaky test. Would you mind checking #11750 ?

@rdhabalia
Copy link
Contributor Author

thanks @lhotari for reporting, I will check the failure.

@rdhabalia
Copy link
Contributor Author

rdhabalia commented Aug 23, 2021

it's fixed by: #11753

bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…e#11725)

* PIP 83 : Pulsar Reader: Message consumption with pooled buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants