[Broker] Remove subscription when closing Reader on non-persistent topics #11731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the subscription will not be removed when closing the non-persistent topic reader.
Modifications
Add a new field
isDurable
in NonPersistentSubscription, if the field is false the non-persistent subscription should be removed when closing the subscription(Such as a Reader subscription), or the subscription will be retained(Such as a Consumer subscription).Verifying this change
Add a new unit test to verify the reader subscription could be removed.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
For committer
For this PR, do we need to update docs?
no-need-doc
label and explain why.