[pulsar-client] clean up MultiTopicsConsumerImpl reference on consumer creation failure #11754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
sijie,
eolivelli,
codelipenghui and
nkurihar
…r creation failure
merlimat
approved these changes
Aug 24, 2021
merlimat
added
type/bug
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…r creation failure (apache#11754)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partitioned-topic Consumer doesn't cleanup the resources when it fails to create consumer, and it creates memory leak if consumer creation is keep failing with non-recoverable error (eg:
BusySubscriptionError) which makes application unstable. One of the issue isunAckedMessageTrackertimer, which still keeps consumer reference even after closing the timer-task in cleanup method and consume-creation failure introduces memory leak with objects associated with timer-task.Modification
Close and clean timer task references.