[Tests] Use TestRetrySupport for BaseMetadataStoreTests to cleanup state between retries #11771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate between retries - mitigates flaky tests in LockManagerTest apache#11690 and ZkSessionTest apache#11032
This was referenced Aug 25, 2021
lhotari
requested review from
315157973,
BewareMyPower,
codelipenghui,
hangc0276 and
zymap
eolivelli
reviewed
Aug 25, 2021
| protected TestZKServer zks; | ||
|
|
||
| @BeforeClass(alwaysRun = true) | ||
| void setup() throws Exception { | ||
| @Override | ||
| protected void setup() throws Exception { |
There was a problem hiding this comment.
Should we remove AfterClass/BeforeClass annotations?
There was a problem hiding this comment.
no, TestRetrySupport doesn't change that in any way.
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 25, 2021
…ate between retries (apache#11771) * [Tests] Use TestRetrySupport for BaseMetadataStoreTests to cleanup state between retries - mitigates flaky tests in LockManagerTest apache#11690 and ZkSessionTest apache#11032 * [Tests] Add notes about the correct usage of TestRetrySupport (cherry picked from commit 7de9992)
|
There's an additional change #11778 which is needed for making the test reties work for BaseMetadataStoreTests. |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ate between retries (apache#11771) * [Tests] Use TestRetrySupport for BaseMetadataStoreTests to cleanup state between retries - mitigates flaky tests in LockManagerTest apache#11690 and ZkSessionTest apache#11032 * [Tests] Add notes about the correct usage of TestRetrySupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attempt to mitigate the flaky tests in LockManagerTest #11690 and ZkSessionTest #11032 which use the BaseMetadataStoreTests base class. Test retries didn't succeed since the state didn't get cleaned between tests.
The downside of better test retries is that it might suppress production issues in metadata store implementation. The flakiness might be a sign of a real problem.
Modifications