Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-client-tools] fix packages tool parameter desc #11809

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

freeznet
Copy link
Contributor

Motivation

fix the parameter's description in packages client tool

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

For contributor

For this PR, do we need to update docs?

  • If yes, please update docs or create a follow-up issue if you need help.

  • If no, please explain why.

For committer

For this PR, do we need to update docs?

  • If yes,

    • if you update docs in this PR, label this PR with the doc label.

    • if you plan to update docs later, label this PR with the doc-required label.

    • if you need help on updating docs, create a follow-up issue with the doc-required label.

  • If no, label this PR with the no-need-doc label and explain why.

@freeznet freeznet self-assigned this Aug 27, 2021
@freeznet freeznet added doc-not-needed Your PR changes do not impact docs release/2.8.2 labels Aug 27, 2021
@freeznet freeznet added this to the 2.9.0 milestone Aug 27, 2021
@freeznet freeznet changed the title fix packages tool parameter desc [pulsar-client-tools] fix packages tool parameter desc Aug 27, 2021
@sijie sijie merged commit 44becbf into apache:master Sep 2, 2021
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
### Motivation

fix the parameter's description in packages client tool

(cherry picked from commit 44becbf)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation

fix the parameter's description in packages client tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants