-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testclient] hide option -s and substitute -ss(0) for it #11828
Conversation
PTAL and approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @eolivelli @codelipenghui |
Thanks for your contribution. Does this affect only master or other versioned docs? |
This only affects maser and the version that will be released later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like we are not handling compatibility.
with this change the 'subscriberName' parameter is ignored.
that is worse than letting the user see an error.
IMHO we should support the old parameter, it is only a matter of handling it as one single value in subscriptions or something like that
So we don’t need to make any changes? If this is the case I will close this PR. |
I believe that you can "hide" the parameter I am not sure if it is worth. what about deprecating "-ss" and let "-s" behave like "-ss" ? |
…criptions first element for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@MMirelli you may be interested in this patch
…criptions first element for it (apache#11828)
Fixes #11827
Motivation
Option
--subscriber-name
is redundant and easy to cause interference when the size of--subscriptions
is equal to 1 but--num-subscriptions
is not equal to 1 in commandbin/pulsar-perf consume
.Modifications
--subscriber-name
--subscriber-name
with--subscriptions first element