[pulsar-functions] Pass SubscriptionPosition from FunctionDetails to FunctionConfig / SinkConfig
#11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeznet
added
type/bug
gaoran10
reviewed
Aug 30, 2021
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
Outdated
Show resolved
Hide resolved
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
Outdated
Show resolved
Hide resolved
michaeljmarshall
approved these changes
Aug 31, 2021
sijie
approved these changes
Sep 2, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 18, 2021
… to `FunctionConfig` / `SinkConfig` (#11831) * pass SubscriptionPosition from FunctionDetails to config * address comment * reduce code duplication * set subscriptionPosition in FunctionConfig, SinkConfig with init value * fix default values * fix CI * revert init data * fix CI * fix CI * fix CI (cherry picked from commit bfd6542)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
… to `FunctionConfig` / `SinkConfig` (apache#11831) * pass SubscriptionPosition from FunctionDetails to config * address comment * reduce code duplication * set subscriptionPosition in FunctionConfig, SinkConfig with init value * fix default values * fix CI * revert init data * fix CI * fix CI * fix CI (cherry picked from commit bfd6542) (cherry picked from commit dbddfe5)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
… to `FunctionConfig` / `SinkConfig` (apache#11831) * pass SubscriptionPosition from FunctionDetails to config * address comment * reduce code duplication * set subscriptionPosition in FunctionConfig, SinkConfig with init value * fix default values * fix CI * revert init data * fix CI * fix CI * fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FunctionDetails defined
SubscriptionPosition, but the value is not converted back toFunctionConfig/SinkConfigand will causeSubscriptionPositionlost.Modifications
Pass
SubscriptionPositionfromFunctionDetailstoFunctionConfig/SinkConfigVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
internal bug fix
doc
(If this PR contains doc changes)