Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulsar-functions-go] sync to the latest function proto #11853

Merged

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Aug 31, 2021

Motivation

Pulsar 2.8 makes some changes on functions proto, but the changes has not been sync to pulsar-go-function. This PR regenerate the proto files based on the latest functions proto files.

Modifications

  • update pulsar-functions-go's proto files

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    internal update

  • doc

    (If this PR contains doc changes)

@freeznet freeznet added this to the 2.9.0 milestone Aug 31, 2021
@freeznet freeznet self-assigned this Aug 31, 2021
@freeznet
Copy link
Contributor Author

/pulsarbot run-failure-checks

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit f784379 into apache:master Sep 1, 2021
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
* update to the latest proto

* fix license

(cherry picked from commit f784379)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants