[Schema] Schema compatibility strategy in broker level. #11856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
codelipenghui,
sijie,
gaoran10 and
eolivelli
and removed request for
sijie
gaoran10
reviewed
Aug 31, 2021
| doc = "The schema compatibility strategy in broker level. If this config in namespace policy is `UNDEFINED`" | ||
| + ", schema compatibility strategy check will use it in broker level." | ||
| ) | ||
| private String schemaCompatibilityStrategy = "UNDEFINED"; |
There was a problem hiding this comment.
Could we use the name of the enum SchemaCompatibilityStrategy.UNDEFINED.
There was a problem hiding this comment.
We should be able to directly use the enum type here
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Show resolved
Hide resolved
added 2 commits
August 31, 2021 18:12
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
congbobo184
added
the
doc-required
hangc0276
added
release/2.8.2
cherry-picked/branch-2.8
Anonymitaet
added
doc-complete
codelipenghui
added
cherry-picked/branch-2.9
|
@eolivelli This PR is already in branch-2.9 and will be released in 2.9.1. So I remove the label |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
## Motivation link apache#11849 Schema compatibility strategy config in broker level. ## implement If namespace schema compatibility strategy is `UNDEFINED`, use broker schema compatibility strategy
congbobo184
deleted the
congbobo184_broker_level_schema_SchemaCompatibilityStrategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
link #11849
Schema compatibility strategy config in broker level.
implement
If namespace schema compatibility strategy is
UNDEFINED, use broker schema compatibility strategyVerifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)