-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[function] enable protobuf-native schema support for function #11868
Merged
sijie
merged 3 commits into
apache:master
from
streamnative:neng/function-protobuf-native
Sep 2, 2021
Merged
[function] enable protobuf-native schema support for function #11868
sijie
merged 3 commits into
apache:master
from
streamnative:neng/function-protobuf-native
Sep 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
Sep 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test for the schema PROTOBUF_NATIVE
?
eolivelli
approved these changes
Sep 1, 2021
added a test class for |
/pulsarbot run-failure-checks |
freeznet
approved these changes
Sep 2, 2021
sijie
approved these changes
Sep 2, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 9, 2021
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
…#11868) Fixes apache#11721 ### Motivation Enable function proces topic with protobuf_native schema ### Modifications update `TopicSchema` (cherry picked from commit d0e5d96) (cherry picked from commit c0bada6)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…#11868) Fixes apache#11721 ### Motivation Enable function proces topic with protobuf_native schema ### Modifications update `TopicSchema`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/function
cherry-picked/branch-2.8
Archived: 2.8 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.8.2
release/2.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11721
Motivation
Enable function proces topic with protobuf_native schema
Modifications
update
TopicSchema
Verifying this change
Verified locally, the function is able to log the incoming message
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
internal fix
doc
(If this PR contains doc changes)