Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[function] enable protobuf-native schema support for function #11868

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

nlu90
Copy link
Member

@nlu90 nlu90 commented Aug 31, 2021

Fixes #11721

Motivation

Enable function proces topic with protobuf_native schema

Modifications

update TopicSchema

Verifying this change

  • Make sure that the change passes the CI checks.

Verified locally, the function is able to log the incoming message

Received Person: name: "SN-EM-0"
email: "0sn@streamnative.io"

Received Person: name: "SN-EM-1"
id: 1
email: "1sn@streamnative.io"

Received Person: name: "SN-EM-2"
id: 2
email: "2sn@streamnative.io"
  • Also added a new unit test class to test the functionality

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    internal fix

  • doc

    (If this PR contains doc changes)

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Sep 1, 2021
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test for the schema PROTOBUF_NATIVE?

@nlu90
Copy link
Member Author

nlu90 commented Sep 1, 2021

Could we add a test for the schema PROTOBUF_NATIVE?

added a test class for TopicSchema. PTAL

@nlu90
Copy link
Member Author

nlu90 commented Sep 2, 2021

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.9.0 milestone Sep 2, 2021
@sijie sijie merged commit d0e5d96 into apache:master Sep 2, 2021
@sijie sijie deleted the neng/function-protobuf-native branch September 2, 2021 04:48
codelipenghui pushed a commit that referenced this pull request Sep 9, 2021
Fixes #11721 

### Motivation

Enable function proces topic with protobuf_native schema

### Modifications

update `TopicSchema` 

(cherry picked from commit d0e5d96)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 9, 2021
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Oct 27, 2021
…#11868)

Fixes apache#11721

### Motivation

Enable function proces topic with protobuf_native schema

### Modifications

update `TopicSchema`

(cherry picked from commit d0e5d96)
(cherry picked from commit c0bada6)
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…#11868)

Fixes apache#11721 

### Motivation

Enable function proces topic with protobuf_native schema

### Modifications

update `TopicSchema`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[function] support protobuf_native schema type in pulsar functions
7 participants