[Branch-2.7][Broker] Fix using partitioned topic name to get topic policies #11897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
requested review from
codelipenghui,
eolivelli,
315157973 and
congbobo184
gaoran10
added
component/topic-policy
type/bug
codelipenghui
approved these changes
Sep 2, 2021
315157973
approved these changes
Sep 2, 2021
congbobo184
approved these changes
Sep 6, 2021
| @@ -593,8 +593,6 @@ public void testTlsEnabledWithoutNonTlsServicePorts() throws Exception { | |||
|
|
|||
| } catch (Exception e) { | |||
| fail("should not fail"); | |||
| } finally { | |||
There was a problem hiding this comment.
If close the pulsarClient, it will cause other test methods can't use the pulsarClient and there is a clean operation after the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug that using the partitioned topic name to get topic policies. The PR #11294 fix this issue, but it's hard to cherry-pick the PR to
branch-2.7, so create this PR to fix the issue inbranch-2.7.This PR contains PR-11294 and PR-11863.
Modifications
Verifying this change
The test method
TopicPoliciesTest#testBacklogQuotaWithPartitionedTopicis used to verify getting topic policies by the partitioned topic name.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)