[C++] Move all C symbols into C++ pulsar namespace #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
merlimat
requested review from
sijie,
rdhabalia,
jerrypeng,
codelipenghui and
BewareMyPower
BewareMyPower
approved these changes
Sep 6, 2021
merlimat
added a commit
that referenced
this pull request
Sep 7, 2021
* [C++] Move all C symbols into C++ pulsar namespace * Fixed formatting * Fixed include to be outside of namespace scope
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* [C++] Move all C symbols into C++ pulsar namespace * Fixed formatting * Fixed include to be outside of namespace scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have few C objects that are included in the C++ libpulsar, from LZ4 and CRC imported code.
While we're hiding all internal symbols in the libpulsar.so, we cannot control the visibility for libpulsar.a.
Since these symbols do not have any kind of prefix, they can conflict with existing symbols from the application or its depedencies (eg: if it's already linking with liblz4).
Modifications
Convert the C sources into C++ source and include all symbols into
pulsarC++ namespace.